Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

在windows平台上支持卡名复制 #2675

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

yybbwc
Copy link
Contributor

@yybbwc yybbwc commented Feb 14, 2025

No description provided.

@purerosefallen
Copy link
Collaborator

I have no Windows environment. Could someone review it? @salix5 @mercury233 @Wind2009-Louse

gframe/game.cpp Outdated
myswprintf(formatBuffer, L"%ls[%08d]", dataManager.GetName(cd.alias), cd.alias);
else
myswprintf(currentCardName, L"「%ls」", dataManager.GetName(cd.alias));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non ASCII char may cause problem

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do user need quote when coping card name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do user need quote when coping card name?

有些卡名中带有空格,用引号括起来更能表示空格两端是一个整体

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non ASCII char may cause problem

我能想到的麻烦是,当有人把文件用非utf8编码打开时,会看到乱码。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non ASCII char may cause problem

但为了避免人看到乱码而主动采用\u进行表达,相当于已经提前把可读字符进行了乱码处理(人脑难读)。

@mercury233
Copy link
Collaborator

I don't think this feature is useful, but Irrlicht has copyToClipboard
https://github.com/Fluorohydride/ygopro/pull/2577/files#diff-b1d9142d178315b60f07453f713b27edf4b42505fe187835d5a1fc5a829ea7c2R391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants