[BUGFIX] Fix v:try in compiled context without f:else or with else ar…

…gument
FluidTYPO3 · Aug 8, 2024 · f06986b · f06986b
1 parent a0d26ab
commit f06986b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/Classes/ViewHelpers/TryViewHelper.php b/Classes/ViewHelpers/TryViewHelper.php
@@ -106,9 +106,13 @@ public static function renderStatic(
             $content = $arguments['__then']();
         } catch (\Exception $error) {
             $variableProvider = $renderingContext->getVariableProvider();
-            $variableProvider->add('exception', $error);
-            $content = $arguments['__else']();
-            $variableProvider->remove('exception');
+            if (isset($arguments['__else'])) {
+                $variableProvider->add('exception', $error);
+                $content = $arguments['__else']();
+                $variableProvider->remove('exception');
+            } else {
+                $content = $arguments['else'] ?? null;
+            }
         }
         return $content;
     }

diff --git a/Tests/Unit/ViewHelpers/TryViewHelperTest.php b/Tests/Unit/ViewHelpers/TryViewHelperTest.php
@@ -28,6 +28,14 @@ public function testRenderStaticWithException(): void
         self::assertSame('else case', $output);
     }
 
+    public function testRenderStaticWithExceptionAndElseArgument(): void
+    {
+        $arguments['__then'] = function() { throw new \Exception('test'); };
+        $arguments['else'] = 'else case';
+        $output = TryViewHelper::renderStatic($arguments, function() { return ''; }, $this->renderingContext);
+        self::assertSame('else case', $output);
+    }
+
     public function testRenderWithException(): void
     {
         $instance = $this->getMockBuilder($this->getViewHelperClassName())->setMethods(['renderElseChild', 'renderChildren'])->getMock();
@@ -38,4 +46,14 @@ public function testRenderWithException(): void
         $result = $instance->render();
         $this->assertEquals('testerror', $result);
     }
+
+    public function testRenderWithExceptionAndElseArgument(): void
+    {
+        $instance = $this->getMockBuilder($this->getViewHelperClassName())->setMethods(['renderChildren'])->getMock();
+        $instance->setRenderingContext($this->renderingContext);
+        $instance->setArguments(['else' => 'else']);
+        $instance->expects($this->once())->method('renderChildren')->willThrowException(new \RuntimeException('testerror'));
+        $result = $instance->render();
+        $this->assertEquals('else', $result);
+    }
 }