Add Regex type #18
Add Regex type #18
Conversation
Sources/Structs/Regex.swift
Outdated
| // Created by Frederick Pietschmann on 19.03.18. | ||
| // Copyright © 2018 Flinesoft. All rights reserved. | ||
| // | ||
| // Taken from https://github.com/sharplet/Regex, then modified to remove some weight. |
There was a problem hiding this comment.
Use Originally from: https://... instead. Also place a second whitespace at the beginning to allign with the above.
Sources/Structs/Regex.swift
Outdated
| /// | ||
| /// - returns: `true` if the regular expression matches, otherwise `false`. | ||
| public func matches(_ string: String) -> Bool { | ||
| return !matches(in: string).isEmpty |
There was a problem hiding this comment.
I feel like this is enough reason to also introduce the firstMatch method and use it here. This implementation will be very slow (even in average) if the underlying text is a long text. Using firstMatch here would improve the average performance a lot for many cases. Please also note that the firstMatch(in:) should be public as I feel like it's needed as often as matches(in:) -> [Match]) is.
|
Any updates on this? |
|
@Dschee I added the first match interface as suggested, while documentation and tests are yet to be created. |
Sources/Structs/Regex.swift
Outdated
| /// | ||
| /// - returns: An optional `Match` describing the first match, or `nil`. | ||
| /// | ||
| /// - note: If the match is successful, the result is also stored in `Regex.lastMatch`. |
There was a problem hiding this comment.
Not sure if this is true. You removed the lastMatch, no?
|
Nice, seems like only a new README section is missing, no? Thank you very much for all the work done so far. 👍 |
|
@Dschee You're welcome. With the readme now being done, this PR is now ready to merge if there aren't any issues / further suggestions. |
|
Looks good, merging. 🎉 |
This is my suggestion for Regex in HandySwift. Please comment on whether this is suitable.
Note: It's not tested and documented yet, I will do that on approval.
Would close #14.