Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kron #383

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Add kron #383

wants to merge 31 commits into from

Conversation

AdvancedCompiler
Copy link
Contributor

PR Category

Operator

Type of Change

New Feature

Description

Implement kron operator

Issue

#259

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

微信图片_20241231101248

@iclementine iclementine self-assigned this Jan 2, 2025
iclementine
iclementine requested changes Jan 10, 2025
View reviewed changes
src/flag_gems/ops/kron.py Outdated Show resolved Hide resolved
src/flag_gems/ops/kron.py Outdated Show resolved Hide resolved
src/flag_gems/ops/kron.py Outdated Show resolved Hide resolved
src/flag_gems/ops/kron.py Show resolved Hide resolved
src/flag_gems/ops/kron.py Outdated Show resolved Hide resolved
src/flag_gems/ops/kron.py Outdated Show resolved Hide resolved
src/flag_gems/ops/kron.py Show resolved Hide resolved
src/flag_gems/ops/kron.py Outdated Show resolved Hide resolved
tests/test_special_ops.py Outdated Show resolved Hide resolved
tests/accuracy_utils.py Show resolved Hide resolved
tongxin
tongxin reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@tongxin tongxin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a more simple and composable way to implement this function is reshape the inputs and call elementwise mul.

src/flag_gems/ops/kron.py Outdated Show resolved Hide resolved
src/flag_gems/ops/kron.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph0375 ph0375 ph0375 left review comments

@tongxin tongxin tongxin left review comments

@iclementine iclementine Awaiting requested review from iclementine

Requested changes must be addressed to merge this pull request.

Assignees

@iclementine iclementine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AdvancedCompiler @tongxin @iclementine @ph0375 @henghengxiedaima @shuailong616