-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 네이버 즐겨찾기 저장 #73
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
02f9110
style : replace <p> tags with <span> tag
keemsebin 5045556
feat : implement useNaverMapPlace hook
keemsebin 2d6b922
refactor: update SharedResponse type with optional properties
keemsebin ca1cd3a
refactor: rename youtubeLink to link
keemsebin a6998b3
fix: add optional parameter to onNext function
keemsebin 9bfb592
fix : rename SharedResponse to ExtractResponse
keemsebin 9afdf27
feat: add useNaverPlace hook to Link component
keemsebin 3f12822
feat: implement YouTube extraction and Shared Naver bookmark results …
keemsebin a58f5f6
chore : remove docker version
keemsebin 6f37c10
feat : add useNaverBookMark hooks
keemsebin 03a8447
feat: add handling for NaverBookmark mutation
keemsebin 9fc1d12
chore : remove comment
keemsebin 8e4969a
style: change Typography component tag from span to p
keemsebin c338853
chore : rename naverMutate
keemsebin 0ab05a8
refactor: use div with key for rendering bookmark items
keemsebin 81227a2
feat: update Chip component to handle object and string types
keemsebin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
version: '3.8' | ||
|
||
services: | ||
react-app: | ||
build: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/components/features/BottomSheetContent/BottomSheetContent.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
import { FlowType } from '@/constants/funnelStep'; | ||
import { ExtractResponse } from '@/hooks/api/link/useYoutubePlace'; | ||
import { useBottomFunnel } from '@/hooks/common/useBottomFunnel'; | ||
|
||
import { BottomSheetContentProps } from './types'; | ||
|
||
import { YoutubeResponse } from '../../../hooks/api/link/useYoutubePlace'; | ||
import { Place } from '../../../types/naver'; | ||
|
||
export const BottomSheetContent = ({ type, data }: BottomSheetContentProps) => { | ||
return useBottomFunnel({ type: type as FlowType, data: data as Place[] | YoutubeResponse }); | ||
return useBottomFunnel({ type: type as FlowType, data: data as Place[] | ExtractResponse }); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import { useMutation } from '@tanstack/react-query'; | ||
|
||
import { ExtractResponse } from '@/hooks/api/link/useYoutubePlace'; | ||
import { post } from '@/lib/axios'; | ||
|
||
export const useNaverBookmark = (token: string) => { | ||
return useMutation({ | ||
mutationFn: (naverData: ExtractResponse) => | ||
post(`api/bookmarks/naver`, naverData, { | ||
headers: { | ||
Authorization: `Bearer ${token}`, | ||
}, | ||
}), | ||
}); | ||
}; | ||
keemsebin marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { useMutation } from '@tanstack/react-query'; | ||
|
||
import { post } from '@/lib/external'; | ||
|
||
import { ExtractResponse } from './useYoutubePlace'; | ||
|
||
export type NaverMapLink = { | ||
url: string; | ||
}; | ||
|
||
export const useNaverMapPlace = () => { | ||
return useMutation<ExtractResponse, Error, NaverMapLink>({ | ||
mutationFn: ({ url }) => | ||
post<ExtractResponse>('naver_bookmark', { | ||
url, | ||
}), | ||
retry: 1, | ||
}); | ||
}; | ||
keemsebin marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
타입 가드를 사용하여 타입 안전성을 개선해주세요.
현재 구현은 타입 단언(type assertion)을 사용하고 있어 런타임 오류가 발생할 수 있습니다.
다음과 같이 개선하는 것을 추천드립니다:
이렇게 수정하면:
majorCategory
속성의 존재 여부를 확인할 수 있습니다📝 Committable suggestion