Get current version from git tag #390
Conversation
facuMH
requested review from
jmpike,
thaarok,
HerbertJordan and
jenikd
as code owners
| vsn += "-" + gitDate | ||
| } | ||
| return vsn | ||
| } | ||
|
|
||
| func AsString() string { | ||
| // meta is not used for now, so we ignore it. | ||
| versionMajor, versionMinor, versionPatch, _ := parseVersion(Version) |
There was a problem hiding this comment.
By moving the version number parsing from the init code to a lazy-evaluated place, you effectively made the final sonicd version command in the Makefile for checking whether the version string could be correctly parsed useless -- since it is just printing the Version constant.
There was a problem hiding this comment.
even if parseVersion is called in init, it just initializes the 3 version variables, which are only used when comparing version with the network. Both sonicd and sonictool when running version cmd, they just return the Version. I can change it back to have parseVersion in the init, but it does not affect the version cmds
There was a problem hiding this comment.
If it is in the init it does affect the version command in the sense that it gets executed. And if there is a parsing error in the version number that causes the parser to panic because of a very miss-shaped version tag, then we would detect it immediately at the end of the build.
The way it is now, we would only see it crashing if AsString() is called, which basically never happens. Would be bad if this would happen the first time in production.
facuMH
force-pushed
the
facundo/tag_to_version
branch
from
dfd1aaa to
ca0da37
Compare
This PR adds a mechanism that uses the git tag (if any) as release version. Hence preventing the task to update both the version file as well as the release tag in git. It also should check if there have been any commits since the last label, and if the build is a dirty build (aka has uncommitted changes)
the git tag is "v2.0.1" => Major=2, Minor=0, Patch=1, Meta=""
the git tag is "v2.0.1-rc1" => Major=2, Minor=0, Patch=1, Meta="rc1"
the git tag is "v2.0.1" but there are extra commits on top: => Major=2, Minor=0, Patch=1, Meta="dev"
the git tag is "v2.0.1-rc1" with extra commits on top => Major=2, Minor=0, Patch=1, Meta="rc1-dev"
there is no git tag (e.g. development) => handle like "v0.0.0" with extra commits on top