Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carmen checkpoint #1142

Merged
merged 23 commits into from
Sep 2, 2024
Merged

Carmen checkpoint #1142

merged 23 commits into from
Sep 2, 2024

Conversation

cabrador
Copy link
Collaborator

@cabrador cabrador commented Aug 12, 2024 •
edited by wsodsong
Loading

Description

This PR adds ability to set how often will Carmen create checkpoints

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

@cabrador cabrador changed the base branch from main to develop August 12, 2024 08:20
@cabrador
Merge remote-tracking branch 'origin/petr/carmen-checkpoint' into pet…
44975f8 
…r/carmen-checkpoint

# Conflicts:
#	utils/config.go
#	utils/default_config.go
@cabrador
Fix after merge
60315e4
@cabrador
Add logging
2b81a70
@cabrador cabrador marked this pull request as ready for review August 20, 2024 08:50
wsodsong
wsodsong reviewed Aug 22, 2024
View reviewed changes
cmd/aida-vm-sdb/run_substate.go Outdated Show resolved Hide resolved
executor/extension/statedb/live_db_block_checker.go Show resolved Hide resolved
utils/default_config.go Outdated Show resolved Hide resolved
utils/statedb.go Outdated Show resolved Hide resolved
utils/statedb.go Outdated Show resolved Hide resolved
wsodsong
wsodsong previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@wsodsong wsodsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments of cli argument names, everything else looks good.

utils/flags.go Outdated Show resolved Hide resolved
utils/flags.go Outdated Show resolved Hide resolved
@cabrador cabrador requested a review from wsodsong August 27, 2024 14:02
wsodsong
wsodsong previously approved these changes Aug 28, 2024
View reviewed changes
@cabrador cabrador changed the title [WIP] Carmen checkpoint Carmen checkpoint Aug 28, 2024
@cabrador cabrador mentioned this pull request Aug 28, 2024
Merged
2 tasks
wsodsong
wsodsong previously approved these changes Aug 28, 2024
View reviewed changes
@wsodsong wsodsong merged commit 57d96ec into develop Sep 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsodsong wsodsong wsodsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cabrador @wsodsong