fixes from comments

Fantom-foundation · Aug 29, 2024 · 170f8e6 · 170f8e6
1 parent 6f760b2
commit 170f8e6
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/state/carmen.go b/state/carmen.go
@@ -327,10 +327,12 @@ func (s *carmenStateDB) GetLogs(common.Hash, uint64, common.Hash) []*types.Log {
 }
 
 func (s *carmenStateDB) PointCache() *utils.PointCache {
+	// this should not be relevant for revisions up to Cancun
 	panic("PointCache not implemented")
 }
 
 func (s *carmenStateDB) Witness() *stateless.Witness {
+	// this should not be relevant for revisions up to Cancun
 	return nil
 }
 

diff --git a/state/memory.go b/state/memory.go
@@ -404,11 +404,13 @@ func (db *inMemoryStateDB) GetLogs(txHash common.Hash, block uint64, blockHash c
 }
 
 func (db *inMemoryStateDB) PointCache() *utils.PointCache {
+	// this should not be relevant for revisions up to Cancun
 	panic("PointCache not implemented")
 }
 
 // Witness retrieves the current state witness being collected.
 func (db *inMemoryStateDB) Witness() *stateless.Witness {
+	// this should not be relevant for revisions up to Cancun
 	return nil
 }
 

diff --git a/state/proxy/logger.go b/state/proxy/logger.go
@@ -308,7 +308,7 @@ func (s *loggingVmStateDb) PointCache() *utils.PointCache {
 // Witness retrieves the current state witness.
 func (s *loggingVmStateDb) Witness() *stateless.Witness {
 	res := s.db.Witness()
-	s.writeLog("Witness, %v", res)
+	s.writeLog("Witness, %s", res)
 	return res
 }
 

diff --git a/state/substate.go b/state/substate.go
@@ -107,11 +107,13 @@ func (db *offTheChainDB) TrieDB() *triedb.Database {
 }
 
 func (db *offTheChainDB) PointCache() *utils.PointCache {
+	// this should not be relevant for revisions up to Cancun
 	panic("PointCache not implemented")
 }
 
 // Witness retrieves the current state witness being collected.
 func (db *offTheChainDB) Witness() *stateless.Witness {
+	// this should not be relevant for revisions up to Cancun
 	return nil
 }