Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not attempt to load world on Folia servers #225

Merged

Conversation

Grabsky
Copy link
Contributor

@Grabsky Grabsky commented Jan 10, 2025

This operation is unsupported on Folia. We should instead refuse to load NPCs in worlds that were not loaded by the server initially.

Fixes #211

@Grabsky Grabsky marked this pull request as draft January 10, 2025 12:32
@Grabsky Grabsky force-pushed the fix/folia-world-loading branch from 14e7f71 to 1d6a036 Compare January 10, 2025 12:37
@Grabsky Grabsky force-pushed the fix/folia-world-loading branch from 1d6a036 to 71a8e24 Compare January 10, 2025 12:38
@Grabsky Grabsky changed the title don't load create world on Folia servers do not attempt to load world on Folia servers Jan 10, 2025
@Grabsky Grabsky marked this pull request as ready for review January 10, 2025 12:38
@Euphillya
Copy link

@Grabsky
Copy link
Contributor Author

Grabsky commented Jan 10, 2025

Not really a solution imo. We don't want to accidentally break someone's server or world because of that. Folia developers must have a valid reason for marking that operation as unsupported.

@Euphillya
Copy link

Not really a solution imo. We don't want to accidentally break someone's server or world because of that. Folia developers must have a valid reason for marking that operation as unsupported.

It is marked Not Supported because world loading is not currently possible. So they are temporarily disabled both loading and unloading worlds.

After disabling it is totally legit for now, I wanted to give the example as an indication

@OakLoaf
Copy link
Contributor

OakLoaf commented Jan 10, 2025

I don't personally think FancyNPCs should be touching world loading at all in general. Aside from listening to the WorldLoadEvent

@OliverSchlueter OliverSchlueter merged commit 7a1d961 into FancyMcPlugins:main Jan 10, 2025
@Grabsky Grabsky deleted the fix/folia-world-loading branch January 11, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnsupportedOperationException on Folia
4 participants