Fix suggestion: #214 : Virtual Threads are not a good idea. #218
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Euphillya
changed the title
Euphillya
changed the title
|
I'll inform myself more about virtual threads and find out if it's an actual issue. Did you experience a server crashing because of this? |
yes of course, we had to downgrade the version to make everything work again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in my report, virtual threads can completely freeze and cause the plugin to shut down. When this happens, we have to stop the server, which leads to a series of errors because the threads will still try to execute. The more actions are pending, the longer the shutdown process takes.
Maybe later this problem will no longer exist, but in Java 21, it is still present.