Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bunch of fixes to the new interaction system #170

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

Grabsky
Copy link
Contributor

@Grabsky Grabsky commented Sep 24, 2024

  • Added a few missing translations and improved some existing ones. Removed translations that are no longer needed.
  • Fixed {actions_total} placeholder defined in InfoCMD to return sum of all actions rather than triggers count.
  • Made ActionCMD an enum singleton to match other commands. Added a few missing placeholders.
  • Made some minor changes to the README.md file in order to indicate that placeholder-based skins are now supported. Fixed formatting issue where some links were not capitalized.

@Grabsky Grabsky marked this pull request as draft September 24, 2024 18:26
@Grabsky Grabsky marked this pull request as ready for review September 24, 2024 18:27
@OliverSchlueter OliverSchlueter merged commit 18d6710 into FancyMcPlugins:main Sep 25, 2024
@Grabsky Grabsky deleted the fix/nis-fixes branch September 27, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants