Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10 #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #10 #16

wants to merge 1 commit into from

Conversation

thaiat
Copy link

@thaiat thaiat commented Jul 8, 2014

Small fix to issue #10.
Now the VideoSurface applies the classes array

@dmvaldman
Copy link
Contributor

Ah, I see what the problem is. In InputSurface, for instance, we expose an API to set the proper attributes, so for VideoSurface here we would have a setAutoPlay. Then we wouldn't need the .setOptions overwrite that we currently have, and calling setOptions would cascade to Surface's setOptions which would apply your class. Does that make sense?

@thaiat
Copy link
Author

thaiat commented Jul 8, 2014

Hey David,

will be in famo.us lab in about an hour,
let's meet there and discuss it!!!

Avi

@michaelobriena
Copy link

What is the status on this?

@yocontra
Copy link

+1 - Currently having to work around this issue

@MylesBorins
Copy link

@thaiat can you move this to famous/famous?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thaiat @dmvaldman @michaelobriena @yocontra @MylesBorins