Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll tweaks #837

Merged
merged 13 commits into from
Feb 3, 2025
Merged

Scroll tweaks #837

merged 13 commits into from
Feb 3, 2025

Conversation

Robotgiggle
Copy link
Contributor

@Robotgiggle Robotgiggle commented Jan 23, 2025

Various scroll tweaks, taken from #818

  • You can now set the op_id without setting the pattern, which creates a scroll that loads your world's version of the specified pattern when ticked
  • There's now a creative mode tab containing all of the scrolls, including ones from addons, using the above feature to load the correct pattern when you grab one and put it in your inventory
  • The wandering trader now has a chance to sell one random scroll for 12 emeralds, which only reveals its stroke order when you buy it (finally, a way to get scrolls in skyblock!)
  • Config option that controls how likely it is for wandering traders to sell a scroll

This was referenced Jan 23, 2025
Copy link
Member

@SamsTheNerd SamsTheNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small notes

@Robotgiggle Robotgiggle marked this pull request as draft January 25, 2025 00:10
@Robotgiggle Robotgiggle marked this pull request as ready for review January 25, 2025 00:27
Copy link
Member

@SamsTheNerd SamsTheNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some small changes. otherwise code looks fine to me. haven't tested it in-game myself though.

@SamsTheNerd SamsTheNerd enabled auto-merge February 3, 2025 22:45
@SamsTheNerd SamsTheNerd merged commit 7233cc1 into FallingColors:main Feb 3, 2025
4 checks passed
@Robotgiggle Robotgiggle deleted the scroll-tweaks branch February 3, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants