Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge revamp of ru_ru localization + minor en_us fix #832

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

JustS-js
Copy link

@JustS-js JustS-js commented Jan 16, 2025

Love doing pr's at 6 am

Changes:

ru_ru

  • Translated missing entries
  • Translated lore
  • Fixed lots and lots and LOTS of spelling and grammatical mistakes, such as missing declensions, cases, typos and other russian-specific oddities
  • Established parity with vanilla ru_ru localization (blocks and items have a specific naming pattern)
  • Fixed context-based mistakes
  • Probably introduced new typos? dunno i'm not a god

en_us

  • Changed patchouli entry for division action, "dividend" and "divisor" were swapped. Simplified to avoid unnecessary complexity

JustS-js and others added 23 commits January 15, 2025 11:32
New items and additions, fixes for minor spelling and context mistakes
In Minecraft's official ru_ru localization items and blocks (and basically everything else) have only the first letter as capitalized
Some missing categories and entries + parity with vanilla localization
Bro really used google translate and thought we wouldn't notice 💀
NO WAY more fixes??? who could have thought
i literally had to hop in minecraft to test that, divisor and dividend were swapped in the text
@JustS-js JustS-js changed the title Huge revamp of ru_ru localization + minor en_en fix Huge revamp of ru_ru localization + minor en_us fix Jan 22, 2025
@object-Object
Copy link
Member

Thanks for the huge contribution!

Would you be able to rebase this into less commits? At a minimum, one for en_us and one for ru_ru, but a few more would also be fine if there are logical places to split up the changes.

Also, I think all of the current check failures should be fixed by merging in the changes from main, but you'll probably want to wait until after rebasing to do that.

Sorry for the late review.

Copy link
Member

@object-Object object-Object left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see other comment, it won't let me request changes without typing something here)

@JustS-js
Copy link
Author

JustS-js commented Feb 8, 2025

Rebased and squashed all commits into e96930d and 2fa621d and then merged new changes from main into this branch. Also translated itemgroup for scrolls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants