Fix vscode cwd property for subprojects, delete unused runDir property
#1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
approved these changes
Jan 22, 2025
modmuss50
requested changes
Jan 22, 2025
| @@ -140,7 +139,7 @@ public void genRuns() throws IOException { | |||
| toRemove.forEach(configurations::remove); | |||
| configurations.add(configurationJson); | |||
|
|
|||
| Files.createDirectories(Paths.get(configuration.runDir)); | |||
| Files.createDirectories(configuration.absoluteRunDirPath(getProject())); | |||
There was a problem hiding this comment.
You cannot use getProject() during task execution, this is casusing the tests to fail. I might have a look at this.
|
Fixed here: 1c02578 many thanks for the help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ce0a330#diff-cec0045fe90b97a34702058c744a64e1efe8ddf298598a297d2eeb873e108dc2R110 made run configs relative to project.
Then this commit 543e49d#diff-cec0045fe90b97a34702058c744a64e1efe8ddf298598a297d2eeb873e108dc2R162 added an unused
runDirproperty for vscodelaunch.jsonfile, and madecwdproperty non-relative again.