-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filesystem: massively rework how scanning game directories work #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e PAK file and looks for specific files in it's root Used to properly detect Quake game dirs.
a1batross
force-pushed
the
liblist-gameinfo
branch
from
January 7, 2025 06:58
de14b40
to
0bf8d0a
Compare
* No more conversion from liblist.gam to gameinfo.txt. We are using liblist.gam directly now. gameinfo.txt being native format to Xash3D not only remains, it takes priority over liblist.gam. * Quake game directories now don't receive autogenerated gameinfo.txt. * Empty directories don't get gameinfo.txt either, finally making it easier to support HD addon folders. * If user still wishes to generate gameinfo.txt, there is now command fs_make_gameinfo that creates gameinfo.txt for currently running game. * No more creating empty folders for RoDir. They are now created on demand.
…y with dirs_only set to true According to glibc manual, not all filesystems support it and some might return DT_UNKNOWN.
…an extension and some supported ports (like psvita) don't have it
a1batross
force-pushed
the
liblist-gameinfo
branch
from
January 7, 2025 07:10
0bf8d0a
to
8c9b62c
Compare
SNMetamorph
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
is |
No, this is an unofficial extension. I think it's used by its custom launcher, not by the engine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gameinfo.txt
being native format to Xash3D takes priority overliblist.gam
.gameinfo.txt
.gameinfo.txt
either, finally making it easier to support HD addon folders.fs_make_gameinfo
that createsgameinfo.txt
for the currently running game.