Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add premake5 build script #192

Merged
merged 1 commit into from
Oct 18, 2021
Merged

add premake5 build script #192

merged 1 commit into from
Oct 18, 2021

Conversation

izarif
Copy link
Contributor

@izarif izarif commented Oct 16, 2021

I understand that the SDK can be built with CMake or Waf, but the more options the better, right? The script contains only two build configurations (Debug and Release), tested only on Linux and the build with LTO does not work correctly (despite the presence of the --lto command line option).

@mittorn
Copy link
Member

mittorn commented Oct 16, 2021

With hard-coded filelists we cannot support different build systems. cmake still here only because it was used in old engine

@nekonomicon
Copy link
Member

nekonomicon commented Oct 16, 2021

but the more options the better, right?

Nope.
Who will update file lists and build options for all existing branches?

#105

@izarif
Copy link
Contributor Author

izarif commented Oct 16, 2021

Who will update file lists and build options for all existing branches?

I didn't think of that, but premake supports file lists with wildcards. Is it necessary to support all branches? Can the script be kept only for the master branch?

@a1batross
Copy link
Member

Dude, I understand what you wanna say but we decided to not spawn another build system because we supported like seven different build scripts in old engine and it was a big headache.

HLSDK is more of exception because existing modders who use this as a base used CMake so it's still there.

If you wanna keep it for yourself, put it in contrib/iZarif directory so it'll not confuse random strangers who would like to use premake but something is broken, so they'll attach a bug but nobody except you is able to fix it.

@izarif
Copy link
Contributor Author

izarif commented Oct 16, 2021

If you wanna keep it for yourself, put it in contrib/iZarif directory

Moved

@a1batross
Copy link
Member

I'm fine with that.

What do you think @nekonomicon ? If ok, then merge it

@nekonomicon nekonomicon merged commit 9e93646 into FWGS:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants