Placing server 2023 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fourber: use linear position (now published from controller) instead of comparing angular position from talon to linear position from config - add mid safety zone for when the carraige is fully within the collision zone - elevater: publish SAFETY_TO_NO_SAFETY after elevator moves, not before just tested in simulation and it seems to work well, may have missed some edge cases though
BenBean18
force-pushed
the
placing_server_2023
branch
from
39a5db1 to
71c3f73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving over from 2022. also, everything from FRC900/2022RobotCode#212 should be resolved now but i may have missed something