remove gen_default_config.sh / gen_default_everything.sh #546
Conversation
| # | ||
| # default config should be generated after normal custom boards so that it would be default | ||
| # firmware/controllers/generated/rusefi_generated.h file which would be pushed into VCS | ||
| ./gen_config_default.sh |
There was a problem hiding this comment.
I can't find an existing flow that relies on this invocation here; gen-configs.yaml already has this explicitly after the call to this gen_config.sh and is the only flow I could find, unless somehow the GH build containers are re-used on purpose in some scenario/way I'm unaware of.
this is unneeded in this flow, and is a ChibiOS-ism: BUILDDIR, defaults to build, and is created on demand build works w/ alternate BUILDDIR env var / make argument
nmschulte
force-pushed
the
nms/remove-gen-default
branch
from
070b9f7 to
7429422
Compare
| @@ -8,13 +8,7 @@ echo "The storage section of fome.ini is updated as well" | |||
| rm -f gen_config.log | |||
| rm -f gen_config_board.log | |||
|
|
|||
| # todo: who is the consumer of this folder? shall we move that 'mkdir' command closer to usage? | |||
| mkdir build | |||
There was a problem hiding this comment.
the Make build, ChibiOS's BUILDDIR, is this -- it's unnecessary
| @@ -18,7 +18,8 @@ FW_DIR=$(readlink -f $FW_DIR) | |||
| echo "FW dir is $FW_DIR" | |||
| cd $FW_DIR | |||
|
|
|||
| mkdir -p .dep | |||
| mkdir -p .dep # ChibiOS build's DEPDIR | |||
| mkdir -p build # ChibiOS build's BUILDDIR | |||
There was a problem hiding this comment.
this is actually configurable via BUILDDIR, as is I think DEPDIR, but these features are hardcoded in a few places, mainly around the compile.sh layer atop Make.
Invocations like BUILDDIR=shiny/ .../compile.sh / BUILDDIR=shiny/ make indeed land in shiny/, but bits here won't work quite right (see e.g. rm build/fome.bin later in this file).
This just nukes the top-most layer of things; removes dependencies on these files, clarifies a few things, and beginnings of fixes #538