Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabular profile and an example. #232

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Add tabular profile and an example. #232

merged 1 commit into from
Apr 24, 2024

Conversation

rbrush
Copy link
Collaborator

@rbrush rbrush commented Apr 19, 2024

No description provided.

@rbrush rbrush requested review from arjun and johngrimes April 19, 2024 18:35
@arjun
Copy link
Collaborator

arjun commented Apr 21, 2024

@rbrush I installed the IG publisher and locally and getting familiar with the tooling. I believe I should see some indication of select.column.type 1..1 like I do for the URL, name, and fhirVersion constrains but I don't (see screenshot). I may not be refreshing locally correctly...

Are branches getting GH pages sites deployed that I can look at? I think that's only happening for master

image

@rbrush
Copy link
Collaborator Author

rbrush commented Apr 22, 2024

@rbrush I installed the IG publisher and locally and getting familiar with the tooling. I believe I should see some indication of select.column.type 1..1 like I do for the URL, name, and fhirVersion constrains but I don't (see screenshot). I may not be refreshing locally correctly...

Are branches getting GH pages sites deployed that I can look at? I think that's only happening for master

I don't think the build is set up for branches, but I think you want to look at the "Differential Table" or "Snapshot Table" to see that one. I suspect it's not showing up on "Key Elements" because its parent "column" structure is optional, so fields below it would not be considered to be key elements.

@rbrush
Copy link
Collaborator Author

rbrush commented Apr 23, 2024

Based on discussion today, I updated this PR to ensure that no columns are collections and that they can contain only primitive types.

@rbrush rbrush merged commit a6bc27a into master Apr 24, 2024
1 check passed
@rbrush rbrush deleted the tabular_example branch April 24, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants