Add test schema #209
Merged
Add test schema #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jmandel
approved these changes
Feb 23, 2024
Co-authored-by: spicyfalafel <[email protected]>
|
Thank you! I've added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added back a JSON schema to define the structure of the tests.
I actually removed the part that defines the content of the view. The reason for this is that I figured this was at odds with having validation tests that verify the behaviour of the validation going on within the test runner implementations. If the test contains invalid views, they will be invalid tests and therefore never be able to be used to test the runners.
I also added a step to the CI workflow to run this automatically.
Resolves #197.