Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr armv7 pmccntr counter and docs #112

Merged

Conversation

alexeicolin
Copy link
Contributor

perf counters: add PMCCNTR for ARMv7 and add docs

The existing armv7 counter (CNTVCT) does need enabling from kernel mode (so
updated the configure help), and the enable bit is different from the PMU
enable bit (described in the new docs).

Tested on XU4: printed the returned counter values and they look reasonable.

If CNTVCT is not enabled in kernel mode, using the code in the new docs, I get illegal instruction at the instructions that reads CNTVCT.

FWIW, I PRed: thoughtpolice/enable_arm_pmu#6

While at it also did this rename (easy to drop if can't break compatibility with the old --enable-armv8cc):

perf counters: name ARMv8 PMCCNTR_EL0 explicitly

For consistency with the rest.

RFC: It might be worth it to add the kernel module source into this repo, because those linked repos and forks are scattered and seem like they are not maintained. Integrating into the build is probably out of the question due to the need for kernel sources, but maybe at least install the module source into /usr/share, and read the config vars corresponding to --enable* to include the right instructions into that source. Thoughts?

The existing armv7 counter (CNTVCT) does need enabling from kernel mode (so
updated the configure help), and the enable bit is different from the PMU
enable bit (described in the new docs).

Tested on XU4: printed the returned counter values and they look reasonable.
@matteo-frigo matteo-frigo merged commit 1b64d92 into FFTW:master Nov 1, 2017
@matteo-frigo
Copy link
Member

Pulled, thanks.

What's your real name? README-perfcnt should list you as an author.

@SirJosh1987
Copy link

Pulled, thanks.

What's your real name? README-perfcnt should list you as an author.

SirJosh1987 aka no clue what I'm doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants