Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Dockerfile #626

Merged
merged 15 commits into from
Feb 26, 2025
Merged

Clean up Dockerfile #626

merged 15 commits into from
Feb 26, 2025

Conversation

dennisvang
Copy link
Contributor

@dennisvang dennisvang commented Feb 18, 2025

Changes to Dockerfile:

  • single (multi-stage) Dockerfile instead of two
  • run app as spring user instead of root
  • simplified entrypoint and application config files, so we can easily select profile using env variable

fixes #621

the additional build step takes a few seconds extra, but this way we only need to maintain a single file, without duplication
[skip-ci]
@dennisvang
Copy link
Contributor Author

dennisvang commented Feb 18, 2025

@MarekSuchanek Not sure if you rely on the separate (single stage) Dockerfile for commit hook or similar?

fine grained triggers are defined in the  mapping, so we should not need to check for 'created' or 'develop' in the condition
@MarekSuchanek
Copy link
Contributor

@MarekSuchanek Not sure if you rely on the separate (single stage) Dockerfile for commit hook or similar?

I think the single stage Dockerfile was used in the past for building the Docker image in CI... true that it is not needed anymore.

@MarekSuchanek MarekSuchanek self-assigned this Feb 26, 2025
@MarekSuchanek MarekSuchanek merged commit fc751c4 into develop Feb 26, 2025
15 checks passed
@MarekSuchanek MarekSuchanek deleted the issue621-dockerfile branch February 26, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile improvements
2 participants