-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Dockerfile #626
Merged
Merged
Clean up Dockerfile #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conforming to https://docs.docker.com/build/concepts/dockerfile/#filename this also fixes automatic recognition of filetype in intellij
for clarity
and use exec form of entrypoint, instead of shell form
b0bf816
to
7a48028
Compare
the additional build step takes a few seconds extra, but this way we only need to maintain a single file, without duplication
[skip-ci]
3e3b024
to
e5c29f6
Compare
@MarekSuchanek Not sure if you rely on the separate (single stage) Dockerfile for commit hook or similar? |
fine grained triggers are defined in the mapping, so we should not need to check for 'created' or 'develop' in the condition
I think the single stage Dockerfile was used in the past for building the Docker image in CI... true that it is not needed anymore. |
MarekSuchanek
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Dockerfile:
fixes #621