Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clan Ownership refactor #532

Merged
merged 11 commits into from
Jan 8, 2024

add fcaps suggested changes

5849323
Select commit
Loading
Failed to load commit list.
Merged

Clan Ownership refactor #532

add fcaps suggested changes
5849323
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 30, 2023 in 0s

40.55% (-0.63%) compared to b8240d5

View this Pull Request on Codecov

40.55% (-0.63%) compared to b8240d5

Details

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (b8240d5) 41.17% compared to head (5849323) 40.55%.

Files Patch % Lines
src/backend/routes/views/clans/transfer.js 12.50% 14 Missing ⚠️
src/backend/services/ClanManagementRepository.js 0.00% 9 Missing ⚠️
src/backend/services/ClanManagementService.js 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #532      +/-   ##
===========================================
- Coverage    41.17%   40.55%   -0.63%     
===========================================
  Files           71       72       +1     
  Lines         1734     1768      +34     
  Branches       210      214       +4     
===========================================
+ Hits           714      717       +3     
- Misses         988     1019      +31     
  Partials        32       32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov