Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging bug in parseSteamIdFromLoginRedirect #824

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

Ivan-Shaml
Copy link
Member

I have noticed I did a small mistake, i am logging a potentailly malicous request. Most like the Object#toString method will be called so only the memory adress will be logged, but still. Also the log message is misleading nevertheless. Thats why we shouldn't copy-paste :D

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45845f4) 79.00% compared to head (ce53eb6) 79.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #824   +/-   ##
==========================================
  Coverage      79.00%   79.01%           
  Complexity      1271     1271           
==========================================
  Files            243      243           
  Lines           3816     3817    +1     
  Branches         242      242           
==========================================
+ Hits            3015     3016    +1     
  Misses           695      695           
  Partials         106      106           
Files Coverage Δ
...main/java/com/faforever/api/user/SteamService.java 36.00% <100.00%> (+1.30%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45845f4...ce53eb6. Read the comment docs.

@Brutus5000 Brutus5000 merged commit 4e81668 into FAForever:develop Jan 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants