Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reconnect handling to faf server accessor #3061

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #3061 (7ca7086) into develop (8144555) will increase coverage by 0.01%.
The diff coverage is 77.58%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3061      +/-   ##
=============================================
+ Coverage      58.86%   58.87%   +0.01%     
+ Complexity      4455     4452       -3     
=============================================
  Files            558      558              
  Lines          20160    20186      +26     
  Branches        1035     1035              
=============================================
+ Hits           11867    11885      +18     
- Misses          7745     7750       +5     
- Partials         548      551       +3     
Files Coverage Δ
.../com/faforever/client/config/ClientProperties.java 52.41% <100.00%> (ø)
...com/faforever/client/remote/FafServerAccessor.java 80.40% <76.78%> (-0.75%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8144555...7ca7086. Read the comment docs.

@Sheikah45 Sheikah45 merged commit d2aa3a5 into develop Nov 27, 2023
5 checks passed
@Sheikah45 Sheikah45 deleted the maintenance/redo-reconnect branch November 27, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant