Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show division in replays when available #3042

Merged
merged 11 commits into from
Mar 22, 2024

Don't add controllers twice to UI

fb2576a
Select commit
Loading
Failed to load commit list.
Merged

Show division in replays when available #3042

Don't add controllers twice to UI
fb2576a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 22, 2024 in 1s

67.16% of diff hit (target 58.72%)

View this Pull Request on Codecov

67.16% of diff hit (target 58.72%)

Annotations

Check warning on line 266 in src/main/java/com/faforever/client/game/PlayerCardController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/PlayerCardController.java#L266 

Added line #L266 was not covered by tests

Check warning on line 270 in src/main/java/com/faforever/client/game/PlayerCardController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/PlayerCardController.java#L270 

Added line #L270 was not covered by tests

Check warning on line 275 in src/main/java/com/faforever/client/game/PlayerCardController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/PlayerCardController.java#L274-L275 

Added lines #L274 - L275 were not covered by tests

Check warning on line 290 in src/main/java/com/faforever/client/game/PlayerCardController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/PlayerCardController.java#L290 

Added line #L290 was not covered by tests

Check warning on line 294 in src/main/java/com/faforever/client/game/PlayerCardController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/PlayerCardController.java#L294 

Added line #L294 was not covered by tests

Check warning on line 143 in src/main/java/com/faforever/client/game/TeamCardController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/TeamCardController.java#L138-L143 

Added lines #L138 - L143 were not covered by tests

Check warning on line 150 in src/main/java/com/faforever/client/game/TeamCardController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/TeamCardController.java#L145-L150 

Added lines #L145 - L150 were not covered by tests

Check warning on line 163 in src/main/java/com/faforever/client/game/TeamCardController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/TeamCardController.java#L159-L163 

Added lines #L159 - L163 were not covered by tests

Check warning on line 185 in src/main/java/com/faforever/client/game/TeamCardController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/TeamCardController.java#L184-L185 

Added lines #L184 - L185 were not covered by tests

Check warning on line 228 in src/main/java/com/faforever/client/game/TeamCardController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/TeamCardController.java#L228 

Added line #L228 was not covered by tests

Check warning on line 232 in src/main/java/com/faforever/client/game/TeamCardController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/TeamCardController.java#L232 

Added line #L232 was not covered by tests

Check warning on line 149 in src/main/java/com/faforever/client/mapstruct/ReplayMapper.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/mapstruct/ReplayMapper.java#L148-L149 

Added lines #L148 - L149 were not covered by tests

Check warning on line 496 in src/main/java/com/faforever/client/replay/ReplayDetailController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/replay/ReplayDetailController.java#L496 

Added line #L496 was not covered by tests

Check warning on line 500 in src/main/java/com/faforever/client/replay/ReplayDetailController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/replay/ReplayDetailController.java#L498-L500 

Added lines #L498 - L500 were not covered by tests

Check warning on line 560 in src/main/java/com/faforever/client/replay/ReplayDetailController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/replay/ReplayDetailController.java#L560 

Added line #L560 was not covered by tests

Check warning on line 473 in src/main/java/com/faforever/client/replay/ReplayService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/replay/ReplayService.java#L469-L473 

Added lines #L469 - L473 were not covered by tests
View more details on Codecov