Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: labels in multiview got overwritten by source-name #81

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

malmen237
Copy link

What does this do?

This fixes the bug where production-source labels are reset to source-names on multiviews on running productions, when updating alignment or latency on sources or when updating the multiview-layout.

This fix also updates the labels on all layouts connected to that production, if you update the label after the layout has been created.

@malmen237 malmen237 requested a review from Saelmala November 6, 2024 15:29
Copy link

@Saelmala Saelmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malmen237 malmen237 merged commit f5453f0 into main Nov 7, 2024
4 checks passed
@malmen237 malmen237 deleted the fix/label-reset-on-mv-update branch November 7, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants