improve buffered/seeked detection #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinstark
force-pushed
the
feat/improve-bufferd-seeked-detection
branch
from
0e0e2da to
ec88eb0
Compare
martinstark
force-pushed
the
feat/improve-bufferd-seeked-detection
branch
from
ec88eb0 to
bef473a
Compare
|
@bwallberg added wip multi-engine (currently only Shaka) demo app to help testing this change. I'll add the last bits once other things are out of the way. |
|
(build works locally, need to look into what's problematic in actions) |
martinstark
force-pushed
the
feat/improve-bufferd-seeked-detection
branch
from
b61f1b2 to
e4884c4
Compare
martinstark
force-pushed
the
feat/improve-bufferd-seeked-detection
branch
from
422d77f to
78cc38e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
native "playing" triggers when readyState is 3 and, in some browsers, whenever it seems to feel like. It should be more correct to use "canplaythrough" to detect when a buffer or seek is completed.