Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent buggy buffer behaviour in Chrome #391

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

martinstark
Copy link
Collaborator

Check the media element's readyState to see if we should recover from buffering when timeupdate triggers.

Check the media element's ready state to see if
we should recover from buffering when timeupdate
triggers.
Copy link
Collaborator

@bwallberg bwallberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I suggested a small improvement

@martinstark martinstark changed the title fix: prevent buggy buffer behaviour in new Chrome fix: prevent buggy buffer behaviour in Chrome Sep 12, 2024
Copy link
Collaborator

@bwallberg bwallberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinstark martinstark merged commit 66e1e28 into main Sep 12, 2024
2 checks passed
@martinstark martinstark deleted the fix/prevent-buggy-buffer-behaviour-chrome branch September 12, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants