fix: allow triggering of events after a stream has reached the end #217
Conversation
|
@oscnord this is by design ( see https://github.com/Eyevinn/media-event-filter#limitations ), but is something we want so support #3. We just have to test it very thoroughly so that the event flow works properly. |
Ah okay, I should have checked the open issues... 🤦♂️ |
src/media-event-filter.ts
Outdated
| @@ -114,7 +116,7 @@ export const getMediaEventFilter = ({ | |||
| ...initialState, | |||
| }; | |||
|
|
|||
| const isNotReady = (): boolean => state.loading; | |||
| const isNotReady = (): boolean => allowResumeAfterEnded ? state.loading : state.loading || state.ended; | |||
There was a problem hiding this comment.
Isn't this the wrong way around?
There was a problem hiding this comment.
If allowResumeAfterEnded is true we want to allow triggering of events i.e only checking state.loading. If false we want to have the same behaviour as before.
There was a problem hiding this comment.
Or maybe I'm wrong(?)
There was a problem hiding this comment.
if allowResumeAfterEnded ( or maybe allowPlaybackAfterEnded is a clearer name 🤔 ) is true we want the new behavior, if false ( default ) we want the old behavior.
There was a problem hiding this comment.
I'm a dumb dumb, misunderstood the code 🤦
oscnord
force-pushed
the
fix/seeking-in-ended-stream
branch
from
2961eb1 to
4d5c7f6
Compare
oscnord
force-pushed
the
fix/seeking-in-ended-stream
branch
from
4d5c7f6 to
38abf62
Compare
This PR fixes an issue where events wouldn't be emitted after the end state due to
isNotReadybeing set to true even if the video element would trigger play/pause/seek etc.