Feat/visual production #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saelmala
approved these changes
Jan 24, 2025
The problem with this is that production names are not required to be unique, so it might be hard knowing exactly which production to join if you are not familiar with the unique ID if there are several old productions with similar names. It's not pretty, but I think it's better if we ensure that the users have more prominent access to the numerical ID, which is what's used in the URL, and what's needed to manually join a production. |
martinstark
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick Fix!
Added ID to where "Production Name" is displayed, so that the user knows it exists. It used to be part of the launchpage join-call, but was removed with the new UI.
This will preferably be updated so that ID is not the main search-method, that the "Production Name" is searchable instead.