fix: moved variable out of use-effect

Eyevinn · Jan 16, 2025 · f671367 · f671367
1 parent ea8cf8e
commit f671367
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/components/landing-page/join-production.tsx b/src/components/landing-page/join-production.tsx
@@ -66,6 +66,7 @@ export const JoinProduction = ({
   const [isProgramOutputLine, setIsProgramOutputLine] = useState(false);
 
   const { readFromStorage, writeToStorage } = useStorage();
+  const cachedUsername = readFromStorage("username");
 
   const {
     formState: { errors, isValid },
@@ -131,15 +132,14 @@ export const JoinProduction = ({
 
   // Use local cache
   useEffect(() => {
-    const cachedUsername = readFromStorage("username");
     if (cachedUsername) {
       setValue("username", cachedUsername);
     }
 
     if (addAdditionalCallId) {
       setValue("productionId", addAdditionalCallId);
     }
-  }, [addAdditionalCallId, readFromStorage, setValue]);
+  }, [addAdditionalCallId, cachedUsername, setValue]);
 
   // If user selects a production from the productionlist
   useEffect(() => {