Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 717 Indicator Cards (Alerts) - Dashboard #49

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

anagperal
Copy link
Contributor

@anagperal anagperal commented Dec 27, 2024

📌 References

⚠️ Metadata changes:

📝 Implementation

  • Add 717 performance alerts cards in dashboards

📹 Screenshots/Screen capture

image

🔥 Notes to the tester

@anagperal anagperal marked this pull request as ready for review January 2, 2025 08:02
Copy link
Contributor

@9sneha-n 9sneha-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @ana. If we see a perf issue, we can separate datastore keys to smaller objects.

}

getEventTracker717Performance(diseaseOutbreakEventId: Id): FutureData<PerformanceMetrics717[]> {
private getAll717PerformanceIndicators(): FutureData<PerformanceMetrics717[]> {
return this.datastore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we check in network tab if fetching this object takes a long time? If yes, we can have separate keys for each type of 717 indicator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! I think it's a good idea to do now as it's easy and just in case in the future there are more indicators

Base automatically changed from feature/user-upload-case-data to development January 10, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants