-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 717 Indicator Cards (Alerts) - Dashboard #49
base: development
Are you sure you want to change the base?
Create 717 Indicator Cards (Alerts) - Dashboard #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good @ana. If we see a perf issue, we can separate datastore keys to smaller objects.
} | ||
|
||
getEventTracker717Performance(diseaseOutbreakEventId: Id): FutureData<PerformanceMetrics717[]> { | ||
private getAll717PerformanceIndicators(): FutureData<PerformanceMetrics717[]> { | ||
return this.datastore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we check in network tab if fetching this object takes a long time? If yes, we can have separate keys for each type of 717 indicator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! I think it's a good idea to do now as it's easy and just in case in the future there are more indicators
📌 References
dashboard
-->national
,event_tracker
-->event
and added new keyalert
dashboard
andevent_tracker
from datastore and delete old key https://metadata.eyeseetea.com/rsl-zebra240/dhis-web-datastore/index.html#/edit/zebra/717-performance-program-indicators from datstore📝 Implementation
📹 Screenshots/Screen capture
🔥 Notes to the tester