Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Domain entities for zebra #2

Merged
merged 9 commits into from
Jul 8, 2024
Merged

feat: Domain entities for zebra #2

merged 9 commits into from
Jul 8, 2024

Conversation

9sneha-n
Copy link
Contributor

@9sneha-n 9sneha-n commented Jun 12, 2024 •
edited
Loading

📌 References

📝 Implementation

  1. Domain entities for Zebra
  2. Unit test for risk grading calculation which is the only logic so far.

📹 Screenshots/Screen capture

🔥 Notes to the tester

@9sneha-n 9sneha-n marked this pull request as ready for review June 24, 2024 11:28
tokland
tokland reviewed Jun 25, 2024
View reviewed changes
Copy link

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of small details to decide. Comments in-line:

src/domain/entities/DiseaseOutbreak.ts Outdated Show resolved Hide resolved
src/domain/entities/DiseaseOutbreak.ts Outdated Show resolved Hide resolved
src/domain/entities/DiseaseOutbreak.ts Outdated Show resolved Hide resolved
src/domain/entities/DiseaseOutbreak.ts Outdated Show resolved Hide resolved
src/domain/entities/DiseaseOutbreak.ts Outdated Show resolved Hide resolved
src/domain/entities/risk-assessment/RiskAssessmentGrading.ts Show resolved Hide resolved
src/domain/entities/risk-assessment/RiskAssessmentGrading.ts Outdated Show resolved Hide resolved
src/domain/entities/risk-assessment/RiskAssessmentGrading.ts Outdated Show resolved Hide resolved
src/domain/entities/risk-assessment/RiskAssessmentSummary.ts Show resolved Hide resolved
src/domain/entities/risk-assessment/__tests__/RiskAssessmentGrading.spec.ts Outdated Show resolved Hide resolved
@9sneha-n 9sneha-n requested a review from delemaf June 25, 2024 12:00
@9sneha-n 9sneha-n requested a review from tokland June 26, 2024 08:59
@9sneha-n 9sneha-n requested review from tokland and anagperal July 1, 2024 02:06
tokland
tokland reviewed Jul 1, 2024
View reviewed changes
Copy link

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, I forgot to ask about the type/weight relationship on my previous review.

src/domain/entities/DiseaseOutbreakEvent.ts Show resolved Hide resolved
src/domain/entities/risk-assessment/RiskAssessmentGrading.ts Outdated Show resolved Hide resolved
src/domain/entities/risk-assessment/RiskAssessmentGrading.ts Outdated Show resolved Hide resolved
src/domain/entities/risk-assessment/RiskAssessmentGrading.ts Show resolved Hide resolved
src/domain/entities/risk-assessment/__tests__/RiskAssessmentGrading.spec.ts Outdated Show resolved Hide resolved
@9sneha-n 9sneha-n requested a review from tokland July 1, 2024 12:18
tokland
tokland approved these changes Jul 1, 2024
View reviewed changes
Copy link

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

anagperal
anagperal approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@anagperal anagperal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @9sneha-n 🎉

@anagperal
Copy link
Contributor

anagperal commented Jul 5, 2024 •
edited
Loading

@9sneha-n @bhavananarayanan can we merge this PR as the code is approved by all? It's because we'll need for the next PRs

@bhavananarayanan bhavananarayanan merged commit 7581407 into development Jul 8, 2024
1 check passed
@bhavananarayanan bhavananarayanan deleted the feature/domain branch July 8, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anagperal anagperal anagperal approved these changes

@bhavananarayanan bhavananarayanan bhavananarayanan approved these changes

@delemaf delemaf delemaf approved these changes

@tokland tokland tokland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@9sneha-n @anagperal @tokland @delemaf @bhavananarayanan