[HybridApp] Adjust `RCTBootSplash.mm` to HybridApp requirements #56953

war-in · 2025-02-17T16:26:05Z

Explanation of Change

This PR adjusts the RCTBootSplash to related Mobile-Expensify PR requirements

Fixed Issues

$ #57194
PROPOSAL:

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13430

Tests

Open app and see bootsplash opening and closing
Switch between apps and verify if bootsplash behaves correctly

Offline tests

QA Steps

Open app and see bootsplash opening and closing
Switch between apps and verify if bootsplash behaves correctly

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

jnowakow

💯

github-actions · 2025-02-26T09:24:27Z

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

ios/NewExpensify/RCTBootSplash.mm

github-actions · 2025-02-26T10:09:13Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-02-26T10:09:54Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

melvin-bot · 2025-02-26T10:45:00Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ikevin127 · 2025-02-26T20:01:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native ✅

Logged-Out	Logged-In
android-out.mp4	android-in.mp4

Android: HybridApp ✅

Logged-Out	Logged-In
android-hyb-out.mp4	android-hyb-in.mp4

Android: mWeb Chrome ❌

iOS: Native ✅

Logged-Out	Logged-In
ios-out.mp4	ios-in.mp4

iOS: HybridApp ✅

Logged-Out	Logged-In
ios-hyb-out.mp4	ios-hyb-in.mp4

iOS: mWeb Safari ❌

MacOS: Chrome / Safari ❌

MacOS: Desktop ❌

ikevin127 · 2025-02-27T01:58:55Z

From the previous comment:

🟢 I managed to extract the Android: HybridApp link from this run:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56953/index.html

❌ The iOS: HybridApp build failed -> no link from there.

♻️ In the meantime I managed to build and test HybridApp on both Android and iOS -> completed the checklist. I'm awaiting @Expensify/design's validation on the issue's fix then I'll be able to 🟢 Approve.

shawnborton · 2025-02-27T17:52:14Z

@ikevin127 what exactly do you need from the design team? Feel free to tag us again so we know for sure and we can keep this moving along - thanks!

ikevin127

@shawnborton I just needed confirmation from design that the videos from my checklist confirm the bug metioned in the issue's OP is fixed and things look as expected in contrast to what the issue reported as a problem.

🟢 Other than that I think we're good to go, I'll defer to CME for final checks before merge 🚀

Good job on this fix for the author!

shawnborton · 2025-02-28T15:07:53Z

On Android Hybrid, it looks like the logo disappears for a quick sec, and then reappears to do the final animation. It should always stay present until the final out transition. Can we fix that please?

CleanShot.2025-02-28.at.16.06.52.mp4

shawnborton · 2025-02-28T15:11:20Z

It looks like the same thing is happening on Android Native FWIW.

On iOS hybrid, it looks like the animation doesn't play. Also, the boot time is insane (45+ seconds!) - I hope that isn't related to this PR.

iOS Native has a similar issue as Android Hybrid, where the logo disappears for a quick sec and then reappears for the animation:

CleanShot.2025-02-28.at.16.10.27.mp4

So yeah, looks like we still have work to do to get these up to par.

ikevin127 · 2025-02-28T15:21:56Z

These issues mentioned in #56953 (comment) and #56953 (comment), including long boot time are not related to the PR but rather come from me testing in dev mode.

I think in order to clarify the logo issues somebody should trigger native / HybridApp builds on the PR so that people with access can actually test the app already built in staging / prod mode instead of dev mode.

♻️ Reminder that the issue that this PR fixes is detailed by @AndrewGable in this comment, anything else that's not related to that falls outside of the scope of this PR.

shawnborton · 2025-02-28T15:25:04Z

Can do, going to trigger a build now 👍

github-actions · 2025-02-28T15:25:43Z

🚧 @shawnborton has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-02-28T15:51:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56953/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/56953/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56953/NewExpensify.dmg	https://56953.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-02-28T17:15:34Z

Okay cool, tested on iOS above and it feels pretty smooth to me? Maybe @dubielzyk-expensify can give the Android adhoc build a test run too.

dubielzyk-expensify · 2025-03-03T02:40:41Z

I still see a blink on the Android side. Here's a video:

CleanShot.2025-03-03.at.12.40.10.mp4

war-in · 2025-03-04T16:52:41Z

@shawnborton @dubielzyk-expensify the blink is described here

I think we should create a separate issue for that bug because it's not related to the duplicated bootsplash (which we're handling here)

shawnborton · 2025-03-04T16:53:42Z

Cool, that works for me. @AndrewGable thoughts on that?

github-actions · 2025-03-04T17:00:15Z

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

ikevin127 · 2025-03-04T21:58:42Z

@AndrewGable Ready for final review and merge! 🚀

AndrewGable · 2025-03-04T23:28:45Z

Created blink issue here!

AndrewGable · 2025-03-04T23:30:22Z

Mobile-Expensify PR has conflicts so going to hold off on merging this for now.

github-actions · 2025-03-05T09:48:45Z

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

github-actions · 2025-03-06T10:53:41Z

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

OSBotify · 2025-03-06T17:25:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…e-boot-splash-handling [HybridApp] Adjust `RCTBootSplash.mm` to HybridApp requirements (cherry picked from commit 38aeb98) (CP triggered by AndrewGable)

github-actions · 2025-03-06T19:14:29Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.1.9-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-03-06T22:55:21Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.9-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

war-in added 2 commits February 17, 2025 16:56

centralize boot splash in iOS

89c2e3c

Merge branch 'main' into war-in/centralize-boot-splash-handling

f0e832c

jnowakow approved these changes Feb 18, 2025

View reviewed changes

war-in added 3 commits February 20, 2025 15:34

Merge branch 'main' into war-in/centralize-boot-splash-handling

aff1175

Merge branch 'main' into war-in/centralize-boot-splash-handling

f6632d0

fix lint

0f8ec90

war-in mentioned this pull request Feb 26, 2025

[Due for payment 2025-03-17] [Due for payment 2025-03-13] [HybridApp] Improve boot splash screen #57194

Closed

WoLewicki reviewed Feb 26, 2025

View reviewed changes

ios/NewExpensify/RCTBootSplash.mm Show resolved Hide resolved

mountiny added the Ready To Build label Feb 26, 2025

This comment has been minimized.

Sign in to view

war-in marked this pull request as ready for review February 26, 2025 10:44

war-in requested a review from a team as a code owner February 26, 2025 10:44

melvin-bot bot requested review from ikevin127 and removed request for a team February 26, 2025 10:44

This comment was marked as outdated.

Sign in to view

ikevin127 approved these changes Feb 28, 2025

View reviewed changes

melvin-bot bot requested a review from AndrewGable February 28, 2025 11:52

mountiny assigned war-in Mar 2, 2025

Merge branch 'main' into war-in/centralize-boot-splash-handling

b64f2f5

AndrewGable approved these changes Mar 4, 2025

View reviewed changes

Merge branch 'main' into war-in/centralize-boot-splash-handling

6cf4ccc

Merge branch 'main' into war-in/centralize-boot-splash-handling

460073c

AndrewGable merged commit 38aeb98 into Expensify:main Mar 6, 2025
15 checks passed

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Mar 6, 2025

github-actions bot mentioned this pull request Mar 6, 2025

Deploy Checklist: New Expensify 2025-03-04 #57792

Closed

77 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HybridApp] Adjust `RCTBootSplash.mm` to HybridApp requirements #56953

[HybridApp] Adjust `RCTBootSplash.mm` to HybridApp requirements #56953

war-in commented Feb 17, 2025 •

edited

Loading

jnowakow left a comment

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

This comment has been minimized.

melvin-bot bot commented Feb 26, 2025

ikevin127 commented Feb 26, 2025 •

edited

Loading

This comment was marked as outdated.

ikevin127 commented Feb 27, 2025

shawnborton commented Feb 27, 2025

ikevin127 left a comment

shawnborton commented Feb 28, 2025

shawnborton commented Feb 28, 2025

ikevin127 commented Feb 28, 2025

shawnborton commented Feb 28, 2025

github-actions bot commented Feb 28, 2025

github-actions bot commented Feb 28, 2025

shawnborton commented Feb 28, 2025

dubielzyk-expensify commented Mar 3, 2025

war-in commented Mar 4, 2025

shawnborton commented Mar 4, 2025

github-actions bot commented Mar 4, 2025

ikevin127 commented Mar 4, 2025

AndrewGable commented Mar 4, 2025

AndrewGable commented Mar 4, 2025

github-actions bot commented Mar 5, 2025

github-actions bot commented Mar 6, 2025

OSBotify commented Mar 6, 2025

github-actions bot commented Mar 6, 2025

github-actions bot commented Mar 6, 2025

[HybridApp] Adjust RCTBootSplash.mm to HybridApp requirements #56953

[HybridApp] Adjust RCTBootSplash.mm to HybridApp requirements #56953

Conversation

war-in commented Feb 17, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

jnowakow left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

This comment has been minimized.

melvin-bot bot commented Feb 26, 2025

ikevin127 commented Feb 26, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

This comment was marked as outdated.

ikevin127 commented Feb 27, 2025

shawnborton commented Feb 27, 2025

ikevin127 left a comment

Choose a reason for hiding this comment

shawnborton commented Feb 28, 2025

shawnborton commented Feb 28, 2025

ikevin127 commented Feb 28, 2025

shawnborton commented Feb 28, 2025

github-actions bot commented Feb 28, 2025

github-actions bot commented Feb 28, 2025

shawnborton commented Feb 28, 2025

dubielzyk-expensify commented Mar 3, 2025

war-in commented Mar 4, 2025

shawnborton commented Mar 4, 2025

github-actions bot commented Mar 4, 2025

ikevin127 commented Mar 4, 2025

AndrewGable commented Mar 4, 2025

AndrewGable commented Mar 4, 2025

github-actions bot commented Mar 5, 2025

github-actions bot commented Mar 6, 2025

OSBotify commented Mar 6, 2025

github-actions bot commented Mar 6, 2025

github-actions bot commented Mar 6, 2025

[HybridApp] Adjust `RCTBootSplash.mm` to HybridApp requirements #56953

[HybridApp] Adjust `RCTBootSplash.mm` to HybridApp requirements #56953

war-in commented Feb 17, 2025 •

edited

Loading

ikevin127 commented Feb 26, 2025 •

edited

Loading