-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RN 77 upgrade #55861
base: main
Are you sure you want to change the base?
feat: RN 77 upgrade #55861
Conversation
🚧 @mountiny has triggered a test build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
🚧 @mountiny has triggered a test build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
@WoLewicki This might help you here react-native-modal/react-native-modal#781 |
🚧 @mountiny has triggered a test build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Asked QA to test the hybrid |
Bug summary:
|
|
🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
![]() @war-in #55861 (comment) (Space seems to be wrong). Can you fix this? |
#55861 (comment) is still reproducible by the tester bandicam.2025-03-06.08-56-48-560.mp4 |
#55861 (comment) not reproducible anymore. bandicam.2025-03-06.17-14-56-812.mp4 |
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
# Conflicts: # ios/NewExpensifyTests/Info.plist # ios/Podfile.lock # package-lock.json # package.json
|
🚧 @AndrewGable has triggered a test app build. You can view the workflow run here. |
🚧 @AndrewGable has triggered a test app build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
#55861 (comment) This is fixed now |
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Explanation of Change
PR bumping RN to 0.77 and updating dependencies connected with it.
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13394
Fixed Issues
$ #54903
PROPOSAL:
Patches
patches/@react-native+assets-registry+0.76.3.patch
patches/expo+52.0.14+002+rn-75-fixes.patch
patches/expo+52.0.14+003+fix-form-data-entries-override.patch
patches/expo-modules-core+2.1.1+004+fix-type-exports.patch
patches/lottie-react-native+6.5.1+002+bridgeless.patch
patches/react-native+0.76.3+017+Android-onHostResume-resume-frame-callback.patch
patches/react-native+0.76.3+019+keyboard-avoiding-view.patch
patches/react-native+0.76.3+021+fix-selection-not-working.patch
patches/react-native+0.76.3+023+modal-navigation-bar-translucent.patch
patches/react-native+0.76.3+024+hybrid-app.patch
patches/react-native+0.76.3+027+measureText-full-width-if-wraps.patch
patches/react-native+0.76.3+028+fix-scroll-the-cursor-into-view-when-focus.patch
patches/expo+52.0.28+001+dont-change-formdata.patch - upstream PR
patches/jest-expo+52.0.3.patch - upstream PR
patches/react-native-reanimated+3.16.7+004+targets-for-markdown.patch - not available for upstream due to changes in Reanimated core, should be removed when we bump live-markdown version since it was fixed there in Fix linking error
error: undefined symbol: worklets::extractWorkletRuntime
on Android react-native-live-markdown#627patches/react-native-screens+3.35.0+004+cover-all-cases.patch - fixed in 4.x so it will removed when we bump to those versions, hopefully soon
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop