Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: privateKeysAreLocked should be false when seeds removed #87

Merged
merged 3 commits into from
Apr 8, 2024
Merged

fix: privateKeysAreLocked should be false when seeds removed #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9bffcd
chore: add failing test for removeAllSeeds
andrejborstnik Apr 8, 2024
d70f1f7
fix: privateKeysAreLocked should be false when seeds removed
andrejborstnik Apr 8, 2024
a259d63
lint
andrejborstnik Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions features/keychain/module/__tests__/lock-private-keys.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,20 @@ describe('lockPrivateKeys', () => {
keychain.removeAllSeeds()
})

it('should allow usage when locked after removeAllSeeds and re-adding seeds', async () => {
const keychain = createKeychain({ seed })
keychain.lockPrivateKeys()
keychain.removeAllSeeds()
keychain.addSeed(seed)

const keyId = createKeyIdentifierForExodus({ exoType: 'FUSION' })
await keychain.exportKey({
seedId,
keyId,
exportPrivate: true,
})
})

it('should allow exportKey for public keys when locked', async () => {
const keychain = createKeychain({ seed })
keychain.lockPrivateKeys()
Expand Down
1 change: 1 addition & 0 deletions features/keychain/module/keychain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ export class Keychain {

removeAllSeeds() {
this.#masters = Object.create(null)
this.#privateKeysAreLocked = false
}

#getPrivateHDKey = ({ seedId, keyId, getPrivateHDKeySymbol }) => {
Expand Down
Loading