Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (header): Highlight page name on the navigation bar! #202

Merged
merged 4 commits into from
Feb 8, 2024
Merged

feat (header): Highlight page name on the navigation bar! #202

merged 4 commits into from
Feb 8, 2024

Conversation

ArnavK-09
Copy link
Contributor

@ArnavK-09 ArnavK-09 commented Feb 4, 2024 •
edited
Loading

image

Fixes #197

@ArnavK-09
Copy link
Contributor Author

@pnu-s 👋

@ArnavK-09 ArnavK-09 changed the title feat (header.html): Highlight page name on the navigation bar! feat (header): Highlight page name on the navigation bar! Feb 5, 2024
@ArnavK-09 ArnavK-09 mentioned this pull request Feb 5, 2024
Closed
@Jean-BaptisteC Jean-BaptisteC requested a review from pnu-s February 5, 2024 21:02
codeurimpulsif
codeurimpulsif requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@codeurimpulsif codeurimpulsif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, but please don't put CSS style in HTML files, put it in CSS files (themes/hugo-bootstrap/static/assets/css/custom.css seems to be a good place for this).

@ArnavK-09
Copy link
Contributor Author

@codeurimpulsif 👋

codeurimpulsif
codeurimpulsif approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@codeurimpulsif codeurimpulsif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok for me, thanks!

@ArnavK-09
Copy link
Contributor Author

Seems ok for me, thanks!

Merge?

@codeurimpulsif codeurimpulsif merged commit 147809c into Exodus-Privacy:main Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeurimpulsif codeurimpulsif codeurimpulsif approved these changes

@pnu-s pnu-s Awaiting requested review from pnu-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight page name on the navigation bar
2 participants
@ArnavK-09 @codeurimpulsif