-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 02 - Criar Quadro Drag'n'drop #16
Conversation
…nator-frontend into feature/issue_02
…nator-frontend into feature/issue_02
DropResult, | ||
DraggableLocation, | ||
} from 'react-beautiful-dnd'; | ||
import faker, { fake } from 'faker'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Componente fake
e Draggable
não estão sendo utilizados.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved.
|
||
import styles from './ProjectBoard.module.scss'; | ||
|
||
const reorder = (list: any[], startIndex: number, endIndex: number) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seria bom documentar essas funções.
Exemplo:
/**
* Return the sum of two numbers.
* @param a1: number
* @param a2: number
* Return the number, sum of two numbers.
*/
const soma = (a1: number, a2: number): number {
return a1 + a2;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved.
src/pages/Home/index.tsx
Outdated
@@ -1,13 +1,20 @@ | |||
import React from 'react'; | |||
import { RiAddBoxFill, RiAddBoxLine } from 'react-icons/ri'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Componente RiAddBoxLine
não usado.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved.
|
||
return ( | ||
<div className={styles.container}> | ||
<DragDropContext onDragEnd={onDragEnd}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quando tem mais de duas tasks em uma mesma raia aparece uma seta de rolagem, mas fica muito colado no card da task e também fica confuso, pois já tem um "traço" para separar as raias. Não sei se seria possível melhorar isso, mas seria bom. A gente pode optar para deixar isso mais pra frente, visto que é detalhes de design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creio que seja melhor a gente focar em colocar a aplicação para funcionar. Vou criar uma issue para não passar batido.
}; | ||
}; | ||
|
||
const ProjectBoard: React.FC = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Em telas menores algumas informações são escondidas. Como por exemplo o nome da raia "A fazer".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esse problema é o mesmo da issue #15. Vou resolver depois.
Closes #2