Dev.ap/demo formats

[roedoejet]

See EveryVoiceTTS/EveryVoice#617

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
fs2/prediction_writing_callback.py	67% smaller
fs2/tests/test_writing_callbacks.py	54% smaller
fs2/cli/synthesize.py	53% smaller
fs2/model.py	0% smaller

[codecov]

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.01%. Comparing base (87213a9) to head (fab09c5).

Files with missing lines	Patch %	Lines
fs2/cli/synthesize.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   46.97%   47.01%   +0.03%     
==========================================
  Files          22       22              
  Lines        1486     1489       +3     
==========================================
+ Hits          698      700       +2     
- Misses        788      789       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joanise]

I like the refactoring you're doing here, but I'm not sure I like calling get_tokens... directly from everyvoice/demo/app.py. That feels like poor encapsulation to me. And ditto calling save_aligned_text_to_file there.

In fact, choosing spec as the output format causes a crash because that's not how the Spec writer needs to be called.

I think everyvoice/demo/app.py needs to call a function that exists in the base callback class, which you might have to add, so that this all works correctly for each file type in the demo.