Publish wheels #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmurphy4
force-pushed
the
feature/publish-wheels
branch
from
4fb0b4a to
1d8f30c
Compare
We only use `python3.9` in production at the moment. Soon, we'll migrate to `python3.12`. We likely won't ever use any of the other ones..
kmurphy4
force-pushed
the
feature/publish-wheels
branch
from
1d8f30c to
762765b
Compare
kmurphy4
force-pushed
the
feature/publish-wheels
branch
2 times, most recently
from
f1229cf to
b322ee7
Compare
You can verify that this is working correctly by running
$ python -m build --wheel
$ pip install dist/pypff_stubs-0.1.0-py3-none-any.whl
$ mypy -c 'import pypff; reveal_type(pypff.file)'
<string>:1:27: note: Revealed type is "def () -> pypff.file.file"
Success: no issues found in 1 source file
This is based on https://mypy.readthedocs.io/en/latest/installed_packages.html#creating-pep-561-compatible-packages
and https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html.
Otherwise, pushing to a branch with an open PR will trigger two builds.
kmurphy4
force-pushed
the
feature/publish-wheels
branch
2 times, most recently
from
b826892 to
d0baf4c
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the existing upstream CI machinery to publish built wheels to
s3://everlaw-build-artifacts/libpff/. These can then be consumed downstream in the https://github.com/Everlaw/servers repo here: https://github.com/Everlaw/servers/blob/3f49a0c55e2e3328bcfdde166fef8db31f529dc7/dev/bin/install-python-packages#L43-L44Successful run: https://github.com/Everlaw/libpff/actions/runs/11474290833.