Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar flickering issue #292

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix sidebar flickering issue #292

merged 1 commit into from
Jan 14, 2025

Conversation

Yomzy2223
Copy link
Contributor

Fix Sidebar flickering and Misalignment on page reload

This PR fixes sidebar items and Logo flickering and misalignment on page reload

Linked issues

closes EveripediaNetwork/issues#3727

Copy link

stackblitz bot commented Jan 13, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
iq-dashboard ✅ Ready (Inspect) Visit Preview Jan 13, 2025 4:05pm

Copy link

codeclimate bot commented Jan 13, 2025

Code Climate has analyzed commit 4c9b61a and detected 0 issues on this pull request.

View more on Code Climate.

@Yomzy2223 Yomzy2223 requested a review from Damola18 January 13, 2025 16:06
Copy link
Contributor

@Damola18 Damola18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flickering has been fixed, great job

For the alignment, do you think having it center-aligned within that container is a great idea?

Screenshot 2025-01-13 at 17 15 26

I was thinking having the logo aligned with the two nav items will give a more structured look.

@Yomzy2223
Copy link
Contributor Author

The flickering has been fixed, great job

For the alignment, do you think having it center-aligned within that container is a great idea?

Screenshot 2025-01-13 at 17 15 26 I was thinking having the logo aligned with the two nav items will give a more structured look.

Not bad I think. Also, that's what we have on Figma.
Btw, this PR only fixes the flickering issue and misalignment on reload. It didn't modify the design

@Yomzy2223 Yomzy2223 requested review from Damola18 January 13, 2025 16:31
@Damola18
Copy link
Contributor

The flickering has been fixed, great job
For the alignment, do you think having it center-aligned within that container is a great idea?
Screenshot 2025-01-13 at 17 15 26
I was thinking having the logo aligned with the two nav items will give a more structured look.

Not bad I think. Also, that's what we have on Figma. Btw, this PR only fixes the flickering issue and misalignment on reload. It didn't modify the design

What we currently have on prod

Screenshot 2025-01-13 at 17 39 57

What we have currently

Screenshot 2025-01-13 at 17 41 04

@Yomzy2223
Copy link
Contributor Author

The flickering has been fixed, great job
For the alignment, do you think having it center-aligned within that container is a great idea?
Screenshot 2025-01-13 at 17 15 26
I was thinking having the logo aligned with the two nav items will give a more structured look.

Not bad I think. Also, that's what we have on Figma. Btw, this PR only fixes the flickering issue and misalignment on reload. It didn't modify the design

What we currently have on prod

Screenshot 2025-01-13 at 17 39 57 ### What we have currently Screenshot 2025-01-13 at 17 41 04

It's one of the fixes in this PR. The alignment we currently have on prod was introduced by the PR merged yesterday

@Damola18
Copy link
Contributor

The flickering has been fixed, great job
For the alignment, do you think having it center-aligned within that container is a great idea?
Screenshot 2025-01-13 at 17 15 26
I was thinking having the logo aligned with the two nav items will give a more structured look.

Not bad I think. Also, that's what we have on Figma. Btw, this PR only fixes the flickering issue and misalignment on reload. It didn't modify the design

What we currently have on prod

Screenshot 2025-01-13 at 17 39 57 ### What we have currently Screenshot 2025-01-13 at 17 41 04

It's one of the fixes in this PR. The alignment we currently have on prod was introduced by the PR merged yesterday

Okay, that's clarified now

@Yomzy2223 Yomzy2223 merged commit c4ad81f into main Jan 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Sidebar flickering and misalignment on page reload
2 participants