Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't select display: none; or display: contents; elements as scroll parent, as they cannot scroll. #344

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Don't select display: none; or display: contents; elements as scroll parent, as they cannot scroll. #344

merged 1 commit into from
Dec 21, 2023

Conversation

George-Payne
Copy link
Member

@George-Payne George-Payne commented Dec 21, 2023 •
edited
Loading

Sometimes a popover would hide itself as it would choose a display: contents element as it's scroll parent, which has no size.

fixes: UI-366 (properly)

@George-Payne George-Payne added the bug Something isn't working label Dec 21, 2023
@George-Payne George-Payne self-assigned this Dec 21, 2023
@linear Linear
Copy link

linear bot commented Dec 21, 2023

UI-366 Append event type popover is hidden

Nurmaan
Nurmaan approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@Nurmaan Nurmaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@George-Payne George-Payne merged commit dee32f4 into main Dec 21, 2023
1 check passed
@George-Payne George-Payne deleted the get-scroll-parent-fix branch December 21, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nurmaan Nurmaan Nurmaan approved these changes

@teamchong teamchong Awaiting requested review from teamchong

Assignees

@George-Payne George-Payne

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@George-Payne @Nurmaan