Fix 'both' filter in wallet transactions view

[charles-m-knox]

Currently, viewing market transactions in the user's wallet will only show the sold transactions because the IsNone() check in MarketProxyService::CharGetNewTransactions defaults it to 0.

However, a value of 0 is later assumed in MarketDB::GetTransactions to be a "sold" filter (and a "buy" filter is a value of 1).

By updating the defaulted value in MarketProxyService::CharGetNewTransactions to -1 instead of 0, the wallet transactions view now works.

I also made a few minor legibility improvements in one spot in the code, nothing significant.

Summary by Sourcery

Fix the issue with the 'both' filter in the wallet transactions view by changing the default transaction type filter value to -1, ensuring both buy and sell transactions are shown. Enhance code readability with minor formatting improvements.

Bug Fixes:

• Fix the 'both' filter in the wallet transactions view by updating the default value for transaction type filtering from 0 to -1, allowing both buy and sell transactions to be displayed correctly.

Enhancements:

• Improve code legibility in the MarketDB and MarketProxyService by adding spacing and minor formatting adjustments.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes an issue with the 'both' filter in the wallet transactions view. The main change is updating the default value for the 'isBuy' parameter in the MarketProxyService::CharGetNewTransactions function from 0 to -1. This allows the wallet to correctly display both buy and sell transactions. Additionally, some minor code formatting improvements were made for better readability.

File-Level Changes

Change	Details	Files
Update default value for 'isBuy' parameter	Change default value of 'isBuy' from 0 to -1 when 'sellBuy' is None This allows the 'both' filter to work correctly in the wallet transactions view	src/eve-server/market/MarketProxyService.cpp
Improve code readability in MarketDB::GetTransactions	Add blank lines between variable declarations for better separation Adjust formatting of a long if statement condition for clarity	src/eve-server/market/MarketDB.cpp

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @charles-m-knox - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a brief comment explaining why -1 is used as the default value for data.isBuy in MarketProxyService::CharGetNewTransactions. This would help future maintainers understand the reasoning behind this specific value.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[jdhirst]

Looks good to me, thanks for your contribution!