Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index on mktOrders for market speedup #289

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

kenneaal
Copy link

This adds an SQL migration that adds an index on solarSystemID to mktOrders. This significantly speeds up market browsing.

kenneaal added 2 commits June 24, 2024 21:48
Adds an index on solarSystemID to the mktOrders table, to speed up selects on markets, both regional and system-wide.
Add index on mktOrders for market speedup
Copy link

sourcery-ai bot commented Jun 24, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kenneaal - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@jdhirst
Copy link
Contributor

jdhirst commented Jun 27, 2024

@kenneaal thanks for the contribution, looks good to me!

@jdhirst jdhirst merged commit 7ffbc4f into EvEmu-Project:staging Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants