Merge pull request #424 from Esri/feat/groupedBarChartLegend

feat/legendSpacingAndvalueAlign
Esri · Apr 19, 2018 · 2696704 · 2696704
2 parents 48ec6c1 + 6bce91a
commit 2696704
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/packages/cedar-amcharts/src/specs/bar.ts b/packages/cedar-amcharts/src/specs/bar.ts
@@ -9,7 +9,10 @@ export const bar = {
     type: 'column',
     newStack: true
   }],
-  legend: {},
+  legend: {
+    valueAlign: 'left',
+    spacing: 25
+  },
   valueAxes: [ {
     stackType: 'regular'
   } ],

diff --git a/packages/cedar-amcharts/test/data/builtBarSpec.ts b/packages/cedar-amcharts/test/data/builtBarSpec.ts
@@ -16,7 +16,9 @@ const builtBarSpec = {
     }
   ],
   "legend": {
-    "enabled": false
+    "enabled": false,
+    "valueAlign": "left",
+    "spacing": 25
   },
   "valueAxes": [
     {

diff --git a/packages/cedar/CHANGELOG.md b/packages/cedar/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## Unreleased
+### Changed
+- Defaults for pie charts with legends now specify legend valueAlign and spacing
+
 ## [1.0.0-beta.5]
 ### Added
 - One can now add a `style` property which contains `padding` and `pie` properties to `definition`