This repository has been archived by the owner on Feb 5, 2025. It is now read-only.
[WEEKLY RELEASE] HotShot 0.5.84 #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pls148
force-pushed
the
hotshot/rc-0.5.84
branch
from
2f511ca to
bb72a4f
Compare
mrain
reviewed
Jan 23, 2025
shenkeyao
reviewed
Jan 24, 2025
crates/legacy/src/lib.rs
Outdated
There was a problem hiding this comment.
Looks like we can remove this file. No need to address it in this PR. Made an issue: #291.
There was a problem hiding this comment.
Actually we may still need it if we decide to add the VID computation task back.
crates/legacy/src/service.rs
Outdated
Comment on lines
926
to
944
| // tracing::info!("Waiting for vid commitment for block {id}"); | ||
|
|
||
| // let timeout_after = Instant::now() + self.max_api_waiting_time; | ||
|
|
||
| // tracing::info!("Got vid commitment for block {id}",); | ||
|
|
||
| // TODO: Should this still be here? | ||
| // // We got VID in time with margin left. | ||
| // // Maybe we can handle bigger blocks? | ||
| // if timeout_after.duration_since(Instant::now()) | ||
| // > self.max_api_waiting_time / VID_RESPONSE_TARGET_MARGIN_DIVISOR | ||
| // { | ||
| // // Increase max block size | ||
| // self.global_state | ||
| // .write_arc() | ||
| // .await | ||
| // .block_size_limits | ||
| // .try_increment_block_size(truncated); | ||
| // } |
There was a problem hiding this comment.
Nit: Can we delete this commented-out part if no longer needed?
crates/legacy/src/builder_state.rs
Outdated
Comment on lines
795
to
796
| let vid_commitment = | ||
| hotshot_types::traits::block_contents::vid_commitment(&encoded_txns, num_nodes); |
There was a problem hiding this comment.
Forgive my ignorance here. I don't know much about the VID computation. I get from this change that the VID commit computation is quick compared to the VID commit + precompute computation. Is that correct.
pls148
force-pushed
the
hotshot/rc-0.5.84
branch
3 times, most recently
from
181b994 to
0075478
Compare
pls148
force-pushed
the
hotshot/rc-0.5.84
branch
5 times, most recently
from
8157d2e to
ce0acf6
Compare
pls148
force-pushed
the
hotshot/rc-0.5.84
branch
from
ce0acf6 to
e2a6475
Compare
pls148
force-pushed
the
hotshot/rc-0.5.84
branch
from
0ddd9df to
a145a4f
Compare
shenkeyao
approved these changes
Jan 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.