This repository has been archived by the owner on Feb 5, 2025. It is now read-only.
fix: gate no_storage import within test scope #744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xObsidian
requested review from
sveitser,
jbearer and
imabdulbasit
as code owners
|
|
0xObsidian
force-pushed
the
0xObsidian/import-within-test-scope
branch
from
58a5268 to
14554cb
Compare
imabdulbasit
approved these changes
Dec 4, 2024
|
Thank you for your contribution. Please merge main or rebase to fix clippy errors on CI |
Hi @imabdulbasit Thanks for the reply, I will do it today evening |
The `no_storage` module is feature-gated behind `no-storage`, but was being imported at the test module level, causing linter errors when the feature was not enabled. - Linter was failing with error: unresolved import `crate::data_source::storage::no_storage` Implemented Fix --------------- - Moved no_storage import inside the specific test that uses it - Added feature gate to the test: `#[cfg(all(not(target_os = "windows"), feature = "no-storage"))]` - Kept other tests in the module accessible without the feature Testing ------- - Verified linter errors are resolved - Confirmed all tests pass with `cargo nextest run --all-features`
0xObsidian
force-pushed
the
0xObsidian/import-within-test-scope
branch
from
14554cb to
3cfca56
Compare
|
Hi @imabdulbasit, it's done |
|
We have removed the NoStorage feature completely so I am going to close this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
no_storageimport within test scopeno_storagemodule is only imported when the feature flag is enabledKey places to review:
src/availability.rsThings tested
cargo nextest run --all-featuresImplementation Details
The
no_storagemodule is feature-gated behindno-storage, but was being imported at the test module level, causing linter errors when the feature was not enabled. The fix:no_storageimport inside the specific test that uses it#[cfg(all(not(target_os = "windows"), feature = "no-storage"))]Previous Error: