Syncronous Chunks for L1Client #2582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbro
force-pushed
the
tb/destroy-all-async
branch
from
d3a65b5 to
13cabf6
Compare
tbro
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
imabdulbasit
as code owners
tbro
force-pushed
the
tb/destroy-all-async
branch
from
13cabf6 to
1386ad3
Compare
deepugami
pushed a commit
to deepugami/espresso-sequencer
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2506
This PR:
Doesn't close the above, but it is nice to have in preparation for it. We are currently using streams and Futures to poll the L1 in a more or less performant way. This PR changes this to chunk polling synchronously to avoid complications and confusion with nested Futures inside tokio tasks. I split it off from #2506 to hopefully make it easier to review/test.
This PR does not:
It shouldn't change any behavior. The goal is parity with parent commit.
Key places to review:
impls/l1.rsutils/src/syncronous_generator.rsHow to test this PR:
Tests are included. If there are missing tests please comment.